Attention is currently required from: Felix Singer, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60403 )
Change subject: soc/intel/common/cse: Helper API to know CSE SPI Protection Mode
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/60403/comment/0ad97e49_cbf77341
PS3, Line 265: if (!hfs1.fields.mfg_mode)
how would you like deal with new and old definition spi_protection_mode/mfg_mode?
Good Point.
The common part between the older and newer bit definition is remain constant is the SPI being protected for production image as that is when mfg_mode or spi_protection_mode bit is set to 0. So, in that case all we want to know if SPI is protected or not. here is existing code in TGL/ADL which does the same.
https://github.com/coreboot/coreboot/blob/master/src/soc/intel/alderlake/me....
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60403
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23f1a1c4b55d8da6e6fd0cf84bef86f49ce80cca
Gerrit-Change-Number: 60403
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 30 Dec 2021 06:55:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment