Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42842 )
Change subject: mb/amd/mandolin: factor out eMMC GPIO pin mux setup ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42842/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42842/1//COMMIT_MSG@7 PS1, Line 7: EMMC
eMMC
Done
https://review.coreboot.org/c/coreboot/+/42842/1//COMMIT_MSG@9 PS1, Line 9: EMMC
eMMC
Done
https://review.coreboot.org/c/coreboot/+/42842/1/src/mainboard/amd/mandolin/... File src/mainboard/amd/mandolin/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42842/1/src/mainboard/amd/mandolin/... PS1, Line 11: # CONFIG_PICASSO_LPC_IOMUX
Not sure if this comment is worth having
yeah, it's close enough together, so i dropped that comment
https://review.coreboot.org/c/coreboot/+/42842/1/src/mainboard/amd/mandolin/... File src/mainboard/amd/mandolin/gpio.h:
https://review.coreboot.org/c/coreboot/+/42842/1/src/mainboard/amd/mandolin/... PS1, Line 8: EMMC
eMMC
Done