29 Oct
2019
29 Oct
'19
2:56 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36068 )
Change subject: hatch: refactor gpio table into baseboard, allow empty SPDs ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36068/10/src/mainboard/google/hatch... File src/mainboard/google/hatch/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36068/10/src/mainboard/google/hatch... PS10, Line 16: SPD_BIN = $(obj)/spd.bin This can also live within the ifneq block?
--
To view, visit https://review.coreboot.org/c/coreboot/+/36068
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie946cfd7c071824168faa38fd53bd338a5a451e1
Gerrit-Change-Number: 36068
Gerrit-PatchSet: 10
Gerrit-Owner: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Justin TerAvest teravest@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Jett Rink jettrink@google.com
Gerrit-CC: Justin TerAvest teravest@google.com
Gerrit-CC: Keith Short keithshort@google.com
Gerrit-CC: Marco Chen marcochen@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Scott Collyer scollyer@google.com
Gerrit-Comment-Date: Tue, 29 Oct 2019 13:56:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment