Werner Zeh has posted comments on this change. ( https://review.coreboot.org/19693 )
Change subject: soc/intel/apollolake: Enable decoding for ComA and ComB on LPC ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19693/1/src/soc/intel/apollolake/romstage.c File src/soc/intel/apollolake/romstage.c:
PS1, Line 270: if Would it make sense to use else if () here so that if for any reason CONFIG_SOC_UART_DEBUG and CONFIG_DRIVERS_UART_8250IO are both selected the FSP parameters wouldn't be overwritten? Or is that a more theoretical scenario?