Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44524 )
Change subject: mb/google/volteer: Update settings for trackpad on Halvor
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44524/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/halvor/gpio.c:
https://review.coreboot.org/c/coreboot/+/44524/3/src/mainboard/google/voltee...
PS3, Line 112: GPP_F12
Ack
ah, cool, i should have checked the halvor overrides :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44524
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I525ba688f71b7a1893bcb64c77e02c8e2506d7b0
Gerrit-Change-Number: 44524
Gerrit-PatchSet: 3
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 18 Aug 2020 06:24:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: John Su
john_su@compal.corp-partner.google.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment