18 Nov
2020
18 Nov
'20
4:37 a.m.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47640 )
Change subject: drivers/i2c: Add a driver for Semtech SX9324 ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47640/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47640/3//COMMIT_MSG@10 PS3, Line 10:
Plesae add the name and revision of the datasheet.
Done
https://review.coreboot.org/c/coreboot/+/47640/2/src/drivers/i2c/sx9324/sx93... File src/drivers/i2c/sx9324/sx9324.c:
https://review.coreboot.org/c/coreboot/+/47640/2/src/drivers/i2c/sx9324/sx93... PS2, Line 75: D%03.3X
Could be more than one... […]
Make sense. change to SX%2x.
--
To view, visit https://review.coreboot.org/c/coreboot/+/47640
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd582482728a2f535ed85f6696b2f5a4529ba421
Gerrit-Change-Number: 47640
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 18 Nov 2020 03:37:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment