[coreboot-gerrit] Change in coreboot[master]: security/vboot: Add vboot callbacks to support EC software sync

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36208 )

Change subject: security/vboot: Add vboot callbacks to support EC software sync
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36208/8/src/security/vboot/ec_sync.... 
File src/security/vboot/ec_sync.c:

https://review.coreboot.org/c/coreboot/+/36208/8/src/security/vboot/ec_sync.... 
PS8, Line 232: int
> To be honest, I'm not sure if there's a point in using vb2_error_t, if the only return values being  […]

I am fine either ways. I think it is just important to be consistent. We probably need the vb2_error_t for piping it back to vboot, so it might be just easy to have the functions return that and not always update the return types in callback functions. But, I don't see a big problem either ways as long as we are consistent.