Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35864 )
Change subject: mb/lenovo/{t60,r60}: Add ThinkPad R60 support as variant board ......................................................................
Patch Set 43:
(9 comments)
https://review.coreboot.org/c/coreboot/+/35864/43/Documentation/mainboard/le... File Documentation/mainboard/lenovo/r60.md:
PS43: Can you wrap the lines please? (After 80(?) characters?)
https://review.coreboot.org/c/coreboot/+/35864/43/Documentation/mainboard/le... PS43, Line 14: https://thinkpads.com/support/hmm/hmm_pdf/42x3749_02.pdf Make this a line?
[Hardware Maintenance Manual](https://thinkpads.com/support/hmm/hmm_pdf/42x3749_02.pdf)
https://review.coreboot.org/c/coreboot/+/35864/43/Documentation/mainboard/le... PS43, Line 18: This [method](https://gist.github.com/ArthurHeymans/c5ef494ada01af372735f237f6c6adbe) describes a way to install coreboot with vendor firmware still installed on the Lenovo Thinkpad X60, it is reported to also work in Thinkpad R60, with the only difference being the board target you build coreboot for. A feature commit should factor that out into a separate file for *60 devices to avoid duplication.
https://review.coreboot.org/c/coreboot/+/35864/43/Documentation/mainboard/le... PS43, Line 28: - Suspend and resume. In GNU/Linux?
https://review.coreboot.org/c/coreboot/+/35864/43/Documentation/mainboard/le... PS43, Line 30: - GRUB2 and SeaBIOS payloads. What versions?
https://review.coreboot.org/c/coreboot/+/35864/43/Documentation/mainboard/le... PS43, Line 27: - Intel WiFi card. : - Suspend and resume. : - Native graphics initialization. Both legacy VGA and linear framebuffer work. : - GRUB2 and SeaBIOS payloads. : - Reflashing with flashrom (use flashrom-git as of 17.09.2019). : - 2G+1G memory configuration working. Please remove the dots/periods at the end.
https://review.coreboot.org/c/coreboot/+/35864/43/Documentation/mainboard/le... PS43, Line 36: Linux What version?
https://review.coreboot.org/c/coreboot/+/35864/43/Documentation/mainboard/le... PS43, Line 37: picture Please link to the picture.
https://review.coreboot.org/c/coreboot/+/35864/43/Documentation/mainboard/le... PS43, Line 38: - Sometimes it takes several second to run coreboot. Just wait. Might be an outdated EC firmware or missing capacitor on my unit. Please post the logs on the mailing list, if that happens.