Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38378 )
Change subject: drivers/spi/spi_flash: introduce common spi_flash_part_id object ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38378/3/src/drivers/spi/spi_flash_i... File src/drivers/spi/spi_flash_internal.h:
https://review.coreboot.org/c/coreboot/+/38378/3/src/drivers/spi/spi_flash_i... PS3, Line 79: const char *name;
nit: Consider making this an array with hardcoded size (e.g. […]
Please see my latest comment on https://review.coreboot.org/c/coreboot/+/38380
I tried that but because of the long string lengths for some parts we have to have a large enough fixed size array to cover the MAX. As such we can't save the pointer overhead.
https://review.coreboot.org/c/coreboot/+/38378/3/src/drivers/spi/spi_flash_i... PS3, Line 82: uint16_t fast_read_dual_output_support : 1;
nit: add a […]
Done