Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro, Reka Norman, Rishika Raj, Subrata Banik.
Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro, Reka Norman, Rishika Raj, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83949?usp=email
to look at the new patch set (#5).
Change subject: mb/goog/{brya/brox/rex}: unlock gpio wake sources ......................................................................
mb/goog/{brya/brox/rex}: unlock gpio wake sources
The power off code in depthcharge disables all GPEs prior to power off. The problem is that for gpio wake sources that are locked, this power off code cannot successfully clear any pending interrupt from that source. This can result in the device incorrectly waking back up after it's been powered off from the firmware dev screen.
BUG=b:360380950 BRANCH=firmware-brya-14505.B TEST=verify brask, brya, brox, or rex DUT is able to power down and stay powered down when selecting the "Power off" button in the firmware dev screen.
Change-Id: Ic0ac73f8f29761f072d42f35e97198b56d32a9bc Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/brox/variants/jubilant/gpio.c M src/mainboard/google/brox/variants/lotso/gpio.c M src/mainboard/google/brya/variants/baseboard/brask/gpio.c M src/mainboard/google/brya/variants/baseboard/nissa/gpio.c M src/mainboard/google/brya/variants/orisa/gpio.c M src/mainboard/google/brya/variants/trulo/gpio.c 6 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/83949/5