Attention is currently required from: Felix Held, Felix Singer, Jan Samek, Martin L Roth, Nicholas Chin.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75893?usp=email )
Change subject: doc/Makefile: Fix build dir setting
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
The reason for the original was to supply a default value for BUILDDIR at the coreboot makefile level, instead of the SPHINX level, without editing Makefile.sphinx.
Sorry, missed that part (was too focused on the last of Gerrit's mails I read).
I guess I understand the intention. But wonder why would we need the "default
at the coreboot makefile level"? Especially, if it's the same value `_build`.
Was there some later patch supposed to change any of the defaults?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75893?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc44134cf1996592597252aeb9dcf7ffb3378ee3
Gerrit-Change-Number: 75893
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Jan Samek
jan.samek@siemens.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 22 Jun 2023 11:54:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-MessageType: comment