Attention is currently required from: Bao Zheng, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Zheng Bao.
Marshall Dawson has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84195?usp=email )
Change subject: Cezanne: Add an option to enable A/B recovery scheme
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84195/comment/c1e9027a_ffc5e36d?usp... :
PS1, Line 9: Non A/B recovery
Done
Wow, thank you for the additional detail. But please also mention the NDA spec #56995.
Commit Message:
https://review.coreboot.org/c/coreboot/+/84195/comment/f8055c1e_eda98b05?usp... :
PS2, Line 7: Cezanne: Add an option to enable A/B recovery scheme
:
One more nit, please begin this with "soc/amd/cezanne".
If needed for shortness, you can simplify the remaining part down to "add option for A/B recovery".
File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/84195/comment/c440c6a9_323ad592?usp... :
PS1, Line 415: Recovery A/B
I dont know much about vboot's role in A/B recovery.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84195?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id1c8028faee9c544628d65fd77be2a378ed7eab6
Gerrit-Change-Number: 84195
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 04 Sep 2024 15:44:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com