23 Jul
2020
23 Jul
'20
1:46 p.m.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43752 )
Change subject: mb/google/kukui: Add discrete LPDDR4X DDR table support for burnet/esche ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43752/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/sdram_params/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/43752/2/src/mainboard/google/kukui/... PS2, Line 8: dram-params :=
Please indent properly and move 'sdram-params :=' to outside the ifeq block, e.g., […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/43752
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida7ab877c3f7e10a67680b69a1d724ec734d2928
Gerrit-Change-Number: 43752
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 23 Jul 2020 13:46:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Gerrit-MessageType: comment