Patrick Rudolph has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33786 )
Change subject: arch/riscv/mcall: Drop debug code ......................................................................
arch/riscv/mcall: Drop debug code
The printk has no effect as console_init() hasn't been called. Also drop unused variables and headers.
Change-Id: I5bf5a8822c69bbcc3de1de460d19585b8330649f Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33786 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Philipp Hug philipp@hug.cx --- M src/arch/riscv/mcall.c 1 file changed, 0 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Philipp Hug: Looks good to me, approved
diff --git a/src/arch/riscv/mcall.c b/src/arch/riscv/mcall.c index eaef644..afb17c1 100644 --- a/src/arch/riscv/mcall.c +++ b/src/arch/riscv/mcall.c @@ -25,24 +25,15 @@ * MAINTENANCE, SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS. */
-#include <arch/barrier.h> -#include <arch/errno.h> -#include <console/console.h> #include <mcall.h> #include <string.h> #include <vm.h>
-int mcalldebug; // set this interactively for copious debug. - void hls_init(uint32_t hart_id, void *fdt) { - printk(BIOS_SPEW, "hart %d: HLS is %p\n", hart_id, HLS()); memset(HLS(), 0, sizeof(*HLS())); HLS()->fdt = fdt; HLS()->hart_id = hart_id;
mtime_init(); - - printk(BIOS_SPEW, "Time is %p and timecmp is %p\n", - HLS()->time, HLS()->timecmp); }