Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45740 )
Change subject: drivers/spi: Add BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES config
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/45740/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45740/4//COMMIT_MSG@11
PS4, Line 11: We are maintaining the use of
: cbmem for these older platforms because we have no way of validating
: the earlier write back to mrc_cache at this time.
This seems a little out of place.
https://review.coreboot.org/c/coreboot/+/45740/4//COMMIT_MSG@24
PS4, Line 24: GOOGLE_NAMI
Ideally you should also test a board that selects BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES to ensure timeless build looks okay for it too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45740
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3aef8be702f55873233610b8e20d0662aa951ca7
Gerrit-Change-Number: 45740
Gerrit-PatchSet: 4
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 30 Sep 2020 06:01:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment