Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31589 )
Change subject: intelmetool: Add more flag descriptions ......................................................................
intelmetool: Add more flag descriptions
Obtained by inspecting intel SPSinfo tool output
Change-Id: I69eb0dd86761984b6f0a450b7d8757268b0b248e Author: roncapat Signed-off-by: Damien Zammit damien@zamaudio.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31589 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Philipp Deppenwiese zaolin.daisuki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/intelmetool/me.h M util/intelmetool/me_status.c 2 files changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Philipp Deppenwiese: Looks good to me, approved
diff --git a/util/intelmetool/me.h b/util/intelmetool/me.h index dfd5cbb..6a20807 100644 --- a/util/intelmetool/me.h +++ b/util/intelmetool/me.h @@ -33,6 +33,8 @@ #define ME_HFS_CWS_RESET 0 #define ME_HFS_CWS_INIT 1 #define ME_HFS_CWS_REC 2 +#define ME_HFS_CWS_TEST 3 +#define ME_HFS_CWS_DISABLED 4 #define ME_HFS_CWS_NORMAL 5 #define ME_HFS_CWS_WAIT 6 #define ME_HFS_CWS_TRANS 7 @@ -45,6 +47,7 @@ #define ME_HFS_STATE_ERROR 7 #define ME_HFS_ERROR_NONE 0 #define ME_HFS_ERROR_UNCAT 1 +#define ME_HFS_ERROR_DISABLED 2 #define ME_HFS_ERROR_IMAGE 3 #define ME_HFS_ERROR_DEBUG 4 #define ME_HFS_MODE_NORMAL 0 diff --git a/util/intelmetool/me_status.c b/util/intelmetool/me_status.c index 0cc670b..ede3e3a 100644 --- a/util/intelmetool/me_status.c +++ b/util/intelmetool/me_status.c @@ -24,6 +24,8 @@ [ME_HFS_CWS_RESET] = "Reset", [ME_HFS_CWS_INIT] = "Initializing", [ME_HFS_CWS_REC] = "Recovery", + [ME_HFS_CWS_TEST] = "Test", + [ME_HFS_CWS_DISABLED] = "Disabled", [ME_HFS_CWS_NORMAL] = "Normal", [ME_HFS_CWS_WAIT] = "Platform Disable Wait", [ME_HFS_CWS_TRANS] = "OP State Transition", @@ -53,6 +55,7 @@ static const char *me_error_values[] = { [ME_HFS_ERROR_NONE] = "No Error", [ME_HFS_ERROR_UNCAT] = "Uncategorized Failure", + [ME_HFS_ERROR_DISABLED] = "Disabled", [ME_HFS_ERROR_IMAGE] = "Image Failure", [ME_HFS_ERROR_DEBUG] = "Debug Failure" };