Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42459 )
Change subject: device: Add method to configure bus mastering based on Kconfig
......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42459/16/src/device/Kconfig
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/42459/16/src/device/Kconfig@529
PS16, Line 529: and is enabled by default to keep the behaviour for now.
It only has to be done in the payload for devices that are used by the
payload. I'd phrase it as follows:
For security reasons, bus mastering should be enabled as late as
possible. In coreboot, it's usually not necessary and payloads
should only enable it for devices they use. Since not all payloads
enable bus mastering properly yet, this option gives some sort of
"backwards compatibility" and is enabled by default to keep the
traditional behaviour for now. This is currently necessary, for
instance, for libpayload based payloads as the drivers don't enable
bus mastering for PCI bridges.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I876c48ea3fb4f9cf7b6a5c2dcaeda07ea36cbed3
Gerrit-Change-Number: 42459
Gerrit-PatchSet: 16
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Ron Minnich
rminnich@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Mon, 31 Aug 2020 15:56:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment