Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35188 )
Change subject: soc/intel/skylake: lock AES-NI MSR
......................................................................
Patch Set 8:
Patch Set 8: Code-Review-1
According to https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/Library/CpuCommonFe...
this should only be written on thread0 of each core. I've to check additional documentation, but it looks like this could #GP on HT enabled platforms.
This check should be done for all SoCs, for all MSR accesses in MP init.
Thanks Patrick for pointing out, thats the reason i have asked what problem we are seeing if we like to set this msr then right place might be cpu.c where we are running feature programming
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35188
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97a0d3b1b9b0452e929ca07d29c03237b413e521
Gerrit-Change-Number: 35188
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 25 Sep 2019 06:24:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment