Ben Chuang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43751 )
Change subject: drivers/generic/genesyslogic: Add driver for Genesys Loigc GL9763E ......................................................................
Patch Set 1:
(4 comments)
Patch Set 1:
(2 comments)
Welcome to coreboot!
The driver is currently unused, and therefore not build tested. What are you going to use it with?
Hi, I got the GL9763E datasheet. But I am not familiar with the operation of gerrit. Could you teach me how to upload the datasheet ?
https://review.coreboot.org/c/coreboot/+/43751/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43751/1//COMMIT_MSG@7 PS1, Line 7: GL9763E
Could you please mention in the commit message which kind of device the GL9763E is? I couldn't find […]
Yes, it is a PCIe to eMMC controller. I have added this to the commit message.
https://review.coreboot.org/c/coreboot/+/43751/1//COMMIT_MSG@7 PS1, Line 7: Loigc
Logic
fix it. Done
https://review.coreboot.org/c/coreboot/+/43751/1//COMMIT_MSG@7 PS1, Line 7: generic/genesyslogic
I don't think the GL9763E is a "generic" device. I'd put it inside `drivers/genesyslogic/` instead.
Maybe this patch does not look like 'generic'.
But GL9763E is a standard PCIe controller and compliant with PCI Express Base Specification Rev. 1.1. The patches Genesys submitted to Coreboot do not change any PCIe standard behavior on GL9763E.
The purpose of these patches are to reduce the EMI radiation, to improve the read/write performance and to patch one controller hardware bug for GL9763E. With these patches implemented, GL9763E is still PCIe compliance.
Hence, Genesys would like to request Coreboot to categorize GL9763E into “generic device”.
https://review.coreboot.org/c/coreboot/+/43751/1//COMMIT_MSG@8 PS1, Line 8:
Please quickly describe the device, and list the datasheet name and revision you used.
The device is a PCIe to eMMC bridge controller to be used in the Chromebook as the boot disk. The data sheet name is GL9763E and the revision is 02.