Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35992 )
Change subject: nb/intel/gm45: Add C_ENVIRONMENT_BOOTBLOCK support
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/35992/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35992/5//COMMIT_MSG@12
PS5, Line 12: is used.
You mean, if for instance, somebody changes base addresses?
(nice trick to get around moving the code to `bootblock.c` btw. :-P)
https://review.coreboot.org/c/coreboot/+/35992/5/src/northbridge/intel/gm45/...
File src/northbridge/intel/gm45/Kconfig:
https://review.coreboot.org/c/coreboot/+/35992/5/src/northbridge/intel/gm45/...
PS5, Line 30: select BOOTBLOCK_CONSOLE
meh ;)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35992
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f59736cb54377973215f35e35d2cbcd1d82c374
Gerrit-Change-Number: 35992
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Oct 2019 21:03:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment