Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31474 )
Change subject: vboot: standardize on working data size ......................................................................
Patch Set 6:
(3 comments)
Provided everyone is okay with the current method -- then we're stuck waiting for the CQ-DEPEND CL to be downstreamed through vboot git submodule.
https://review.coreboot.org/#/c/31474/2/src/include/memlayout.h File src/include/memlayout.h:
https://review.coreboot.org/#/c/31474/2/src/include/memlayout.h@164 PS2, Line 164: REGION(vboot2_work, addr, CONFIG_VBOOT_WORKING_DATA_SIZE, 16)
I mean, you can put a quick /* 4K gap */ comment in there to make it easier to notice if you want, b […]
I'll just leave it without a note.
https://review.coreboot.org/#/c/31474/2/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/#/c/31474/2/src/security/vboot/Kconfig@95 PS2, Line 95: VBOOT_WORKING_DATA_SIZE
Yeah... like I mentioned on the vboot CL I really don't think that's very clean. […]
Yeah, I guess as long as *which files may be included* is well-defined, we can allow more flexibility than just vb2_api.h. Which is probably necessary if we want to turn vboot_reference into the "toolkit" concept. I also asked a question on the other CL about the other NEED_SHA2_WHATEVER_IT_WAS -- I suppose you've answered it here.
https://review.coreboot.org/#/c/31474/3/src/security/vboot/common.c File src/security/vboot/common.c:
https://review.coreboot.org/#/c/31474/3/src/security/vboot/common.c@43 PS3, Line 43: static const size_t vb2_wd_size = VB2_WORKBUF_RECOMMENDED_SIZE;
This constant doesn't seem useful now, why not just use VB2_WORKBUF_RECOMMENDED_SIZE directly in the […]
Right, let's do that instead.