Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35080 )
Change subject: Documentation/acpi: Add new document on adding ACPI devices to devicetree ......................................................................
Patch Set 6:
(10 comments)
https://review.coreboot.org/c/coreboot/+/35080/5/Documentation/acpi/devicetr... File Documentation/acpi/devicetree.md:
https://review.coreboot.org/c/coreboot/+/35080/5/Documentation/acpi/devicetr... PS5, Line 10: of a
Fits on the line above?
Done
https://review.coreboot.org/c/coreboot/+/35080/5/Documentation/acpi/devicetr... PS5, Line 19: Note that not all mainboards will have the devicetree/overridetree distinction,
Note, not all …
Done
https://review.coreboot.org/c/coreboot/+/35080/5/Documentation/acpi/devicetr... PS5, Line 25: Let's take a look at an example entry from _src/mainboard/google/hatch/variant/hatch/overridetree.cb_:
Use `` to mark up code (monospace).
Done
https://review.coreboot.org/c/coreboot/+/35080/5/Documentation/acpi/devicetr... PS5, Line 84: src/drivers/i2c/generic
``
Done
https://review.coreboot.org/c/coreboot/+/35080/5/Documentation/acpi/devicetr... PS5, Line 86: mainboard's Kconfig file (e.g., src/mainboard/google/hatch/Kconfig) in order
Mark up with ``.
Done
https://review.coreboot.org/c/coreboot/+/35080/5/Documentation/acpi/devicetr... PS5, Line 117: Device
device?
Done
https://review.coreboot.org/c/coreboot/+/35080/5/Documentation/acpi/devicetr... PS5, Line 154: setup
set up
Done
https://review.coreboot.org/c/coreboot/+/35080/5/Documentation/acpi/devicetr... PS5, Line 176: _S0W indicates the deepest S0 sleep state that this device can wake itself
Remove the space at the beginning?
Done
https://review.coreboot.org/c/coreboot/+/35080/5/Documentation/acpi/devicetr... PS5, Line 176: that
Remove.
Done
https://review.coreboot.org/c/coreboot/+/35080/5/Documentation/acpi/devicetr... PS5, Line 182: that supports
supporting
Done