Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32770 )
Change subject: post_code: add post code for failure to load next stage
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32770/3/src/lib/prog_loaders.c
File src/lib/prog_loaders.c:
https://review.coreboot.org/#/c/32770/3/src/lib/prog_loaders.c@166
PS3, Line 166: die("Ramstage was not loaded!\n");
I agree with Patrick. coreboot is reading ramstage out of the ROM chip. […]
Thank you both for the clarification! I updated the 3 references.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32770
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6de6590595d8fcdc57ad156237fffa03d5ead38
Gerrit-Change-Number: 32770
Gerrit-PatchSet: 4
Gerrit-Owner: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 21 May 2019 18:47:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Jett Rink
jettrink@chromium.org
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment