Attention is currently required from: Dinesh Gehlot.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74209 )
Change subject: soc/intel/cmn/block/cse: Implement an API to get ISH version ......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/74209/comment/b4c0657c_40965663 PS4, Line 1216: /* : * This API can only be executed after FSP-M has been initialized. This is because the : * command relies on resources that are not available until CSE DRAM initialization : * command has been sent. : */ Give one space to start with, here is some sample style which u can follow. ``` /* * Initialize the CSE device with provided temporary BAR. If BAR is 0 use a * default. This is intended for pre-mem usage only where BARs haven't been * assigned yet and devices are not enabled. */ ```
https://review.coreboot.org/c/coreboot/+/74209/comment/385edbcf_edc92452 PS4, Line 1227: sizeof(struct fw_version) use directly in line #1229