Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42459 )
Change subject: [RFC] device: Add method for configuring bus master based on config option ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42459/1/src/device/Kconfig File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/42459/1/src/device/Kconfig@519 PS1, Line 519: config PCI_ALLOW_BUS_MASTER
FSP might set it temporarily (didn't check the code), but in our tests it […]
Right, I see the point now. I'd still make this default to y for now and flip it on a per-platform basis once tested, just in case.
https://review.coreboot.org/c/coreboot/+/42459/4/src/include/device/pci.h File src/include/device/pci.h:
https://review.coreboot.org/c/coreboot/+/42459/4/src/include/device/pci.h@13... PS4, Line 131: void pci_configure_bus_master(struct device *dev);
Ack to the `const` but we didn't name it `enable` on purpose, because the point […]
Right, maybe do s/enable/request/ then?
Another detail is the "_dev" part, for consistency with the disable operation