Attention is currently required from: Alicja Michalska, Angel Pons, David Milosevic, Felix Singer, Lean Sheng Tan.
Felix Held has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/83979?usp=email )
Change subject: mb/hardkernel/odroid-h4: Add initial ODROID-H4 series support ......................................................................
Patch Set 7:
(4 comments)
Patchset:
PS2:
Acknowledged
h4 is the base configuration with only 1 ethernet controller, no sata, and a n97 cpu. h4+ adds the second ethernet controller and sata chip and the other one replaces the n97 cpu with one that has double the core count
File src/mainboard/hardkernel/odroid-h4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83979/comment/a6ef1daa_5f6f9d91?usp... : PS7, Line 5: register "pmc_gpe0_dw0" = "GPP_B" : register "pmc_gpe0_dw1" = "GPP_D" : register "pmc_gpe0_dw2" = "GPP_E" do those match what the vendor firmware does? CB:84213 has other values for that and at least the devicetree in that patch seems to be in a better shape than this devicetree
https://review.coreboot.org/c/coreboot/+/83979/comment/400428a8_aff55f31?usp... : PS7, Line 36: device ref tcss_xhci on tcss xhci is unused; the pch xhci controller which is the one used is missing in the devicetree. the usb2 and usb3 port configs are missing in here too
File src/mainboard/hardkernel/odroid-h4/gpio.h:
PS7: i wonder if this is missing the vgpios; at least the other patch for adding the mainboard support has those