Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68939 )
Change subject: mb/starlabs/*: Enable the Mirror flag for boards that support it ......................................................................
mb/starlabs/*: Enable the Mirror flag for boards that support it
Enable the mirror flag for CML and TGL.
Signed-off-by: Sean Rhodes sean@starlabs.systems Change-Id: I51678bdb8d876d238076e12c6315a53c5da59628 Reviewed-on: https://review.coreboot.org/c/coreboot/+/68939 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/starlabs/starbook/Kconfig M src/mainboard/starlabs/starbook/cmos.default M src/mainboard/starlabs/starbook/cmos.layout M src/mainboard/starlabs/starbook/variants/tgl/cmos.default M src/mainboard/starlabs/starbook/variants/tgl/cmos.layout 5 files changed, 21 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/starlabs/starbook/Kconfig b/src/mainboard/starlabs/starbook/Kconfig index f3f50ad..0854c14 100644 --- a/src/mainboard/starlabs/starbook/Kconfig +++ b/src/mainboard/starlabs/starbook/Kconfig @@ -27,6 +27,7 @@ select BOARD_ROMSIZE_KB_16384 select BOARD_STARLABS_STARBOOK_SERIES select EC_STARLABS_MAX_CHARGE + select EC_STARLABS_MIRROR_FLAG select EC_STARLABS_NEED_ITE_BIN select HAVE_INTEL_PTT select HAVE_SPD_IN_CBFS @@ -43,6 +44,7 @@ select DRIVERS_INTEL_USB4_RETIMER select EC_STARLABS_KBL_LEVELS select EC_STARLABS_MAX_CHARGE + select EC_STARLABS_MIRROR_FLAG select EC_STARLABS_NEED_ITE_BIN select MEMORY_MAPPED_TPM select MAINBOARD_HAS_TPM2 diff --git a/src/mainboard/starlabs/starbook/cmos.default b/src/mainboard/starlabs/starbook/cmos.default index f1276cc..b7f77e4 100644 --- a/src/mainboard/starlabs/starbook/cmos.default +++ b/src/mainboard/starlabs/starbook/cmos.default @@ -15,6 +15,7 @@ # EC kbl_timeout=30 seconds fn_ctrl_swap=Disable +mirror_flag=Enable # southbridge power_on_after_fail=Disable # Functions diff --git a/src/mainboard/starlabs/starbook/cmos.layout b/src/mainboard/starlabs/starbook/cmos.layout index 887c0b2..8b6a463 100644 --- a/src/mainboard/starlabs/starbook/cmos.layout +++ b/src/mainboard/starlabs/starbook/cmos.layout @@ -34,6 +34,7 @@ 608 1 e 1 fn_ctrl_swap 616 2 e 8 max_charge 624 2 e 9 fan_mode +632 1 e 1 mirror_flag
# coreboot config options: southbridge 800 2 e 6 power_on_after_fail diff --git a/src/mainboard/starlabs/starbook/variants/tgl/cmos.default b/src/mainboard/starlabs/starbook/variants/tgl/cmos.default index cfc9a61..62bb28d 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/cmos.default +++ b/src/mainboard/starlabs/starbook/variants/tgl/cmos.default @@ -16,6 +16,7 @@ # EC kbl_timeout=30 seconds fn_ctrl_swap=Disable +mirror_flag=Enable # southbridge power_on_after_fail=Disable # Functions diff --git a/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout b/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout index c4a49c5d..d792426 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout +++ b/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout @@ -35,6 +35,7 @@ 608 1 e 1 fn_ctrl_swap 616 2 e 8 max_charge 624 2 e 9 fan_mode +632 1 e 1 mirror_flag
# coreboot config options: southbridge 800 2 e 6 power_on_after_fail