Attention is currently required from: Paul Menzel, Arthur Heymans, Timothy Pearson, Ron Minnich. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57082 )
Change subject: src/mainboard/emulation/qemu-power9: require hb-mode=on ......................................................................
Patch Set 14:
(7 comments)
Patchset:
PS12:
The conditional isn't there to remove unused symbols in ramstage, it's to take change in addressin […]
Updated the patch to only define STACK twice (it's always used in prog_loaders.c and other files). Large conditional might have been an obvious response to warnings about regions being defined out of order that just stuck.
File src/mainboard/emulation/qemu-power9/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/57082/comment/af8958f8_9c415765 PS12, Line 24: STACK(0xa000000, 32K)
I might be wrong but I haven't seen the stage entry move the stack pointer to this so this ends up n […]
Done
https://review.coreboot.org/c/coreboot/+/57082/comment/3124aed5_0a95d4c1 PS12, Line 27: FMAP_CACHE(0xa108000, 4K)
gets migrated to cbmem.
Done
https://review.coreboot.org/c/coreboot/+/57082/comment/6f3feaa9_035edd6c PS12, Line 28: CBFS_MCACHE(0xa109000, 8K)
This gets migrated to cbmem.
Done
https://review.coreboot.org/c/coreboot/+/57082/comment/05504dc4_0888e3fd PS12, Line 29: TIMESTAMP(0xa10b000, 4K)
Is that not in cbmem in ramstage?
Done
https://review.coreboot.org/c/coreboot/+/57082/comment/8b4a55f4_2b9f4273 PS12, Line 30: CBFS_CACHE(0xa10c000, 512K)
Not sure if needed in ramstage.
Done
https://review.coreboot.org/c/coreboot/+/57082/comment/2b878beb_470615d2 PS12, Line 31: PRERAM_CBMEM_CONSOLE(0xf918c000, 128K)
not needed in ramstage
Done