23 Jun
2023
23 Jun
'23
11:29 a.m.
Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76070?usp=email )
Change subject: acpi/acpi.c: Don't set MADT lapic addr on !ENV_X86 ......................................................................
Patch Set 1:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76070/comment/84a8ca2d_e36eee0c : PS1, Line 161: if (ENV_X86) I'm fine with this, but one might consider moving this and the COMMON_MADT conditionals below over to acpi_apic.c. Current expectation is to not see LAPIC or IOAPIC entries for ARM at least?
--
To view, visit https://review.coreboot.org/c/coreboot/+/76070?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e5032fd02af7e8e9ffd2e20aa214a8392ab6335
Gerrit-Change-Number: 76070
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Lance Zhao lance.zhao@gmail.com
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 23 Jun 2023 11:29:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment