Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35763 )
Change subject: soc/intel/skylake: rework and fix platform detection
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35763/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35763/7//COMMIT_MSG@17
PS7, Line 17: this problem in general, depends on platform detection.
but a potential problem.
not only potential, I see this on X11SSM-F
So the real problem is that we make decisions for all groups based on the state of one group...
Yep, and I use LPC now for the detection (hellsenberg suggested this, and then I found that FSP-S does exactly this)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35763
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida60f619308388adc180a5652908e5a947c17c0f
Gerrit-Change-Number: 35763
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 10 Oct 2019 07:14:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment