[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: rework and fix platform detection

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35763 )

Change subject: soc/intel/skylake: rework and fix platform detection
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35763/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35763/7//COMMIT_MSG@17 
PS7, Line 17: this problem in general, depends on platform detection.
> but a potential problem.

not only potential, I see this on X11SSM-F
> So the real problem is that we make decisions for all groups based on the state of one group...

Yep, and I use LPC now for the detection (hellsenberg suggested this, and then I found that FSP-S does exactly this)