build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44724 )
Change subject: soc/mediatek/mt8192: Do dramc runtime config settings ......................................................................
Patch Set 1:
(25 comments)
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_tracking.c:
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 194: MISC_CG_CTRL0_RG_CG_PHY_OFF_DIABLE, 0x0, 'DIABLE' may be misspelled - perhaps 'DISABLE'?
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 285: MISC_CG_CTRL0_RG_CG_PHY_OFF_DIABLE, 0x1, 'DIABLE' may be misspelled - perhaps 'DISABLE'?
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 446: SHU_HWSET_VRCG_HWSET_VRCG_OP, value & ~ BIT(3)); space prohibited after that '~' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 449: static void dramc_shu_tracking_dcm_en_by_sram(const struct ddr_cali* cali) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 548: static void switch_hmr4(const struct ddr_cali* cali, bool en) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 598: mck_p1= READ32_BITFIELD(&ch[chn].phy_ao.byte[b].rk[rk].shu_dqsien_mck_ui_dly, spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 619: mck_p1= READ32_BITFIELD(&ch[chn].phy_ao.byte[b].rk[rk].shu_dqsien_mck_ui_dly, spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 626: write_ui = (mck << mck2ui) +ui; need consistent spacing around '+' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 638: void dramc_dqs_precalculation_preset(const struct ddr_cali* cali) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 646: if (get_shu(cali) == DRAM_DFS_SHU6) { Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 646: if (get_shu(cali) == DRAM_DFS_SHU6) { suspect code indent for conditional statements (9, 17)
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 648: SHU_MISC_PRE_TDQSCK_PRECAL_DISABLE, 0x1); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 648: SHU_MISC_PRE_TDQSCK_PRECAL_DISABLE, 0x1); please, no space before tabs
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 650: MISC_SHU_RX_CG_CTRL_RX_PRECAL_CG_EN, 0x1); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 650: MISC_SHU_RX_CG_CTRL_RX_PRECAL_CG_EN, 0x1); please, no space before tabs
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 651: } else { Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 651: } else { suspect code indent for conditional statements (9, 17)
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 653: SHU_MISC_PRE_TDQSCK_PRECAL_DISABLE, 0x0); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 653: SHU_MISC_PRE_TDQSCK_PRECAL_DISABLE, 0x0); please, no space before tabs
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 655: MISC_SHU_RX_CG_CTRL_RX_PRECAL_CG_EN, 0x0); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 655: MISC_SHU_RX_CG_CTRL_RX_PRECAL_CG_EN, 0x0); please, no space before tabs
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 656: } Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 659: void xrtwtw_shu_setting(const struct ddr_cali* cali) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 677: tx_dly_oen_rk[0][byte]: tx_dly_oen_rk[1][byte]; spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/44724/1/src/soc/mediatek/mt8192/dra... PS1, Line 765: void dramc_runtime_config(const struct ddr_cali* cali) "foo* bar" should be "foo *bar"