[coreboot-gerrit] Change in coreboot[master]: soc/nvidia/tegra124: Correct bitwise operation

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34560 )

Change subject: soc/nvidia/tegra124: Correct bitwise operation
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34560/1/src/soc/nvidia/tegra124/sor... 
File src/soc/nvidia/tegra124/sor.c:

https://review.coreboot.org/c/coreboot/+/34560/1/src/soc/nvidia/tegra124/sor... 
PS1, Line 351: 	reg_val &= ~(APBDEV_PMC_IO_DPD2_REQ_LVDS_ON ||
> The previous &= clears the bits in positions 25, 30, and 31, and then the APBDEV constants in the ne […]

I was talking about || at end of line 351, and expecting it to only clear bit 0. I agree on the change you made already for line 354.