Attention is currently required from: Maulik V Vaghela, Paul Menzel, Sridhar Siricilla, Subrata Banik, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61459 )
Change subject: soc/intel/common: Define enum cpu_type type for core types
......................................................................
Patch Set 3:
(2 comments)
File src/soc/intel/common/block/acpi/cpu_hybrid.c:
https://review.coreboot.org/c/coreboot/+/61459/comment/868c7dc3_a8af726e
PS3, Line 14: cpu_type
Hm, there is already an
`enum cpu_type`
that is in scope here.
Maybe this could be
`enum core_size`
or
`enum cpu_perf_type`
?
https://review.coreboot.org/c/coreboot/+/61459/comment/ae762588_02f535fb
PS3, Line 94: if (global_cpu_type[core_id])
`if (global_cpu_type[core_id] == CPU_TYPE_BIG)`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I740984a437da9d0518652f43180faf9b6ed4255e
Gerrit-Change-Number: 61459
Gerrit-PatchSet: 3
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 31 Jan 2022 20:34:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment