Attention is currently required from: Cliff Huang, Furquan Shaikh, Martin Roth, Rizwan Qureshi, Sridhar Siricilla, Bernardo Perez Priego, Andrew McRae.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55503 )
Change subject: util/cse_serger: Add a new tool for stitching CSE components
......................................................................
Patch Set 24: Code-Review+1
(3 comments)
File util/cbfstool/bpdt_formats/bpdt_1_6.c:
https://review.coreboot.org/c/coreboot/+/55503/comment/970c1329_587f2603
PS22, Line 63: /* TODO(furquan): Need to calculate checksum */
Raised b/202549343 to ensure this gets addressed. I will update the TODO with bug#.
Ack
File util/cbfstool/bpdt_formats/bpdt_1_7.c:
https://review.coreboot.org/c/coreboot/+/55503/comment/7e2a970e_e11ddf03
PS22, Line 210: l->checksum = calculate_layout_checksum(l);
`calculate_layout_checksum()` stashes what is in l->checksum to curr_checksum, sets it to 0 to perfo […]
or a comment?
https://review.coreboot.org/c/coreboot/+/55503/comment/166f3e0b_2fd2a8b9
PS22, Line 317: crc32(0xffff
It is on line 326 below once the checksum is calculated on header and all the entries.
Ah yes ok. caught my eye first time around.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55503
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90dd809b47fd16afdc80e66431312721082496aa
Gerrit-Change-Number: 55503
Gerrit-PatchSet: 24
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Andrew McRae
amcrae@google.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.corp-partner.google.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.corp-partner.google.com
Gerrit-Attention: Andrew McRae
amcrae@google.com
Gerrit-Comment-Date: Mon, 11 Oct 2021 17:44:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment