Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34239 )
Change subject: Documentation: Add FSP bugs
......................................................................
Patch Set 2:
Patch Set 2: Code-Review-1
Patch Set 2:
Patch Set 2: Code-Review+1
CB:34285 has commentary about hiding and locking active PCI devices. But they are probably called "features" now.
As it affects coreboot in a way that you'd call a bug, it's a bug.
Please file a bug report, as I don't know all details there.
I personally try to avoid touching P2SB whenever I can.
[Non-blocking] -1 to bring attention to the requested changes. I agree with this change, though.
What?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34239
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07819b83fb0c9437fc237472dfe943f78738347a
Gerrit-Change-Number: 34239
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 15 Jul 2019 07:14:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment