Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39006 )
Change subject: drivers: Get rid of set_vbe_mode_info_valid ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39006/10/src/include/edid.h File src/include/edid.h:
https://review.coreboot.org/c/coreboot/+/39006/10/src/include/edid.h@109 PS10, Line 109: int row_byte_alignment);
Shouldn't we get rid of this too? I think this was only used to set bytes_per_line.
With this series only some ARM drivers seem to make use of it. Please have a look if it can easily be dropped and the calculations can be moved to the driver.
https://review.coreboot.org/c/coreboot/+/39006/7/src/lib/edid_fill_fb.c File src/lib/edid_fill_fb.c:
PS7:
Should this file still be called edid_fill_lb.c? Sounds more like a framebuffer_info.c to me by now. […]
Done
https://review.coreboot.org/c/coreboot/+/39006/7/src/lib/edid_fill_fb.c@162 PS7, Line 162: fb_new_framebuffer_info_from_edid
Shouldn't this be called fb_set_framebuffer_info_from_edid(), since it's the equivalent of fb_set_fr […]
Done