Attention is currently required from: Kapil Porwal, Rui Zhou, Subrata Banik, Tarun Tuli.
Kun Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75832?usp=email )
Change subject: mb/google/rex/var/screebo: rp0/rp2 change to rp1/rp3
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File src/mainboard/google/rex/variants/screebo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75832/comment/fc37bb7a_f852ffa7 :
PS1, Line 245: device ref tbt_pcie_rp1 on end
: device ref tbt_pcie_rp3 on end
i thought screebo has two type-c ports as tbt_pcie_rp1 and tbt_pcie_rp3 […]
no,rp0 missed modify,screebo has two type-c ports as tbt_pcie_rp1 and tbt_pcie_rp3
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75832?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1013d26c705f2a3f9378d944bd863d94f319d36c
Gerrit-Change-Number: 75832
Gerrit-PatchSet: 6
Gerrit-Owner: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Jinfang Mao
maojinfang@huaqin.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Thu, 15 Jun 2023 11:55:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment