Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33382 )
Change subject: [WIP] mb/google/{sarien, arcada} Fix for SSD can't be detected issue ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/33382/4/src/mainboard/google/sarien/romstage... File src/mainboard/google/sarien/romstage.c:
https://review.coreboot.org/#/c/33382/4/src/mainboard/google/sarien/romstage... PS4, Line 24: * space before *
https://review.coreboot.org/#/c/33382/4/src/mainboard/google/sarien/romstage... PS4, Line 72: gpio_set(GPIO_SSD_RESET, 1); Doesn't GPIO_SSD_RESET get deasserted in BOOT_STATE_INIT_ENTRY(BS_PRE_DEVICE) step anyway? Is this just to deassert the SSD reset earlier on a warm reboot?