Attention is currently required from: Andrey Pronin, Raul Rangel, Yu-Ping Wu, Karthik Ramasubramanian.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59476 )
Change subject: src/security/vboot: Setup secure counter space in TPM NVRAM
......................................................................
Patch Set 1:
(1 comment)
File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/59476/comment/1a149069_a09fc72e
PS1, Line 368: rv = tlcl_read(index, &value, SECURE_COUNTER_SIZE);
actually, it may exist. […]
But that is true for all our TPM spaces. We have never had recovery code from an aborted partial factory init for any of them (and that would be more complicated, because some of them need to be initialized right). It has never been a problem as far as I'm aware. It would be inconsistent to now do it only for this space.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59476
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I915fbdada60e242d911b748ad5dc28028de9b657
Gerrit-Change-Number: 59476
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Andrey Pronin
apronin@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Pronin
apronin@chromium.org
Gerrit-Attention: Andrey Pronin
apronin@google.com
Gerrit-Attention: Andrey Pronin
apronin@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 18 Nov 2021 22:29:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrey Pronin
apronin@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment