Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42498 )
Change subject: ACPI S3: Clean up resume path ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/42498/1/src/arch/x86/acpi_s3.c File src/arch/x86/acpi_s3.c:
https://review.coreboot.org/c/coreboot/+/42498/1/src/arch/x86/acpi_s3.c@94 PS1, Line 94: die("Failed the jump to wakeup vector\n"); We could reset here instead, I think. Not sure if we have a generic reset though.
https://review.coreboot.org/c/coreboot/+/42498/1/src/lib/hardwaremain.c File src/lib/hardwaremain.c:
https://review.coreboot.org/c/coreboot/+/42498/1/src/lib/hardwaremain.c@174 PS1, Line 174: die("Failed OS resume\n"); Should we reset instead?
https://review.coreboot.org/c/coreboot/+/42498/1/src/lib/hardwaremain.c@176 PS1, Line 176: return BS_WRITE_TABLES; this statement is now unreachable