[coreboot-gerrit] [L] Change in coreboot[main]: haswell NRI: Initialise MPLL

[Felix Held (Code Review)]

Attention is currently required from: Angel Pons, Arthur Heymans, Maximilian Brune, Nico Huber.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64184?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: haswell NRI: Initialise MPLL
......................................................................

Patch Set 5:

(1 comment)

File src/northbridge/intel/haswell/native_raminit/init_mpll.c:

https://review.coreboot.org/c/coreboot/+/64184/comment/5cb6abbb_953eabf3 :
PS5, Line 155: 		if (!ctrl->qclkps) {
i wonder what this if statement is for, since qclkps will only be set after the while loop. only had a brief look and didn't look at the patches after this one, so maybe i'm missing something here, but it at least seems to be unexpected