Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/22616 )
Change subject: soc/intel/apollolake: Make use of Intel common Graphics block ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/22616/1/src/soc/intel/apollolake/graphics.c File src/soc/intel/apollolake/graphics.c:
https://review.coreboot.org/#/c/22616/1/src/soc/intel/apollolake/graphics.c@... PS1, Line 93: Do you not need an init function which calls into pci_dev_init?
https://review.coreboot.org/#/c/22616/1/src/soc/intel/apollolake/graphics.c@... PS1, Line 28: return This function doesn't check for dev->enabled any more. Is that intentional?
https://review.coreboot.org/#/c/22616/1/src/soc/intel/apollolake/graphics.c@... PS1, Line 45: /* TODO Initialize Mailbox 3 */ Does this TODO needs to be resolved?
https://review.coreboot.org/#/c/22616/1/src/soc/intel/apollolake/graphics.c@... PS1, Line 62: /* : * TODO This needs to happen in S3 resume, too. : * Maybe it should move to the finalize handler. : */ Does this TODO needs to be resolved?