Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82794?usp=email )
Change subject: mb/google/brox/var/brox: Enable Class-D calibration ......................................................................
mb/google/brox/var/brox: Enable Class-D calibration
DC offset of class-D amplifier is 7mV in Brox which is larger than the expected 3mV. Add a section in the verb table to enable class-D calibration based on the updated verb table provided by Realtek in b:342506575 comment#6.
This improves the offset to be less than 1mV.
BUG=b:342506575 BRANCH=main TEST=Verify DC offset of speaker amplier output is less than 1mV with a multimeter when \ playing -100dB sine waves.
Change-Id: I776f5c24ce3c829cbd64840957c1431608cf2b85 Signed-off-by: Terry Cheong htcheong@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/82794 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Shelley Chen shchen@google.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h 1 file changed, 6 insertions(+), 1 deletion(-)
Approvals: Shelley Chen: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h b/src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h index c0b0eb0..7cf01c2 100644 --- a/src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h +++ b/src/mainboard/google/brox/variants/brox/include/variant/hda_verb.h @@ -9,7 +9,7 @@ /* coreboot specific header */ 0x10ec0256, // Codec Vendor / Device ID: Realtek ALC256 0x10ec12ac, // Subsystem ID - 0x00000013, // Number of jacks (NID entries) + 0x00000014, // Number of jacks (NID entries)
AZALIA_RESET(0x1), /* NID 0x01, HDA Codec Subsystem ID Verb table */ @@ -113,6 +113,11 @@ 0x02046A0C, 0x02050008, 0x02046A0C, + /* Class-D calibration */ + 0x05850000, + 0x0584F880, + 0x05850000, + 0x0584F880, };
const u32 pc_beep_verbs[] = {