[coreboot-gerrit] [M] Change in coreboot[main]: cpu/x86/topology: Simplify CPU topology initialization

[Jérémy Compostella (Code Review)]

Attention is currently required from: Christian Walter, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Ronak Kanabar, Tim Chu.

Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85576?usp=email )

Change subject: cpu/x86/topology: Simplify CPU topology initialization
......................................................................

Patch Set 4:

(1 comment)

File src/cpu/x86/topology.c:

https://review.coreboot.org/c/coreboot/+/85576/comment/f7c85efc_4b689e92?usp... :
PS4, Line 89: 		level = CPUID_CPU_TOPOLOGY_LEVEL(cpuid_regs);
> There got double MACRO CPUID_CPU_TOPOLOGY_LEVEL call nearly, not sure if it is good to combine them  […]

Thank you for your feedback.

I agree that we could just `break` line 89. But I liked the idea of keeping things close to the original code: the loop body is the working case and the `while` test expression is the one breaking the loop. Ideally I could do the assignment in the while test expression but mixing assignment and test is confusing.  Re-working the whole thing with a `for` loop would be my favorite an option but the code is satisfying as-is and it has been widely tested, I do not want to risk to break anything at this stage. 
In addition, the `CPUID_CPU_TOPOLOGY_LEVEL` macro is trivial and that the compiler is most likely going to optimize the test and assignment.

As the patch has been +2 for a little while already, I am going to submit it.