Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Marshall Dawson, Zheng Bao.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49966 )
Change subject: mb/amd/majolica: Add eSPI support
......................................................................
Patch Set 9:
(4 comments)
File src/mainboard/amd/majolica/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/49966/comment/cbaa786a_4f00078d
PS8, Line 7: ESPI_IO_MODE_SINGLE
UEFI is using quad
Done
https://review.coreboot.org/c/coreboot/+/49966/comment/e48f9010_09632db3
PS8, Line 8: ESPI_OP_FREQ_33_MHZ
UEFI is using 16 MHz
Done
https://review.coreboot.org/c/coreboot/+/49966/comment/bb48a700_c689bf19
PS8, Line 11: ,
should be 1
Done
https://review.coreboot.org/c/coreboot/+/49966/comment/43b6923b_bac05d06
PS8, Line 12: 0
1 as well
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49966
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e82a51173f561df560c36528a9b7ec26cf489b5
Gerrit-Change-Number: 49966
Gerrit-PatchSet: 9
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Tue, 02 Mar 2021 01:17:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment