Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/66847 )
Change subject: mb/google/skyrim/port_descriptors: update DDI for MDN and Chausie ......................................................................
mb/google/skyrim/port_descriptors: update DDI for MDN and Chausie
Add two new types for MDN DDI descriptor
BUG=b:228284940 TEST=Normal boot and S0i3 cycles
Signed-off-by: Jason Nien finaljason@gmail.com Change-Id: I02793f032f9855dac202a5aca8666c26426d6cb2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/66847 Reviewed-by: Bao Zheng fishbaozi@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Martin Roth martin.roth@amd.corp-partner.google.com Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-by: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com --- M src/mainboard/amd/chausie/port_descriptors.c M src/mainboard/google/skyrim/port_descriptors.c M src/vendorcode/amd/fsp/mendocino/platform_descriptors.h 3 files changed, 28 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Bao Zheng: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved Marshall Dawson: Looks good to me, approved Nikolai Vyssotski: Looks good to me, but someone else must approve Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/amd/chausie/port_descriptors.c b/src/mainboard/amd/chausie/port_descriptors.c index 17091e7..b10abfa 100644 --- a/src/mainboard/amd/chausie/port_descriptors.c +++ b/src/mainboard/amd/chausie/port_descriptors.c @@ -61,12 +61,12 @@ .hdp_index = DDI_HDP2 }, { /* DDI2 - DP (type C) */ - .connector_type = DDI_DP, + .connector_type = DDI_DP_W_TYPEC, .aux_index = DDI_AUX3, .hdp_index = DDI_HDP3, }, { /* DDI3 - DP (type C) */ - .connector_type = DDI_DP, + .connector_type = DDI_DP_W_TYPEC, .aux_index = DDI_AUX4, .hdp_index = DDI_HDP4, }, diff --git a/src/mainboard/google/skyrim/port_descriptors.c b/src/mainboard/google/skyrim/port_descriptors.c index 808d00b..91316b3 100644 --- a/src/mainboard/google/skyrim/port_descriptors.c +++ b/src/mainboard/google/skyrim/port_descriptors.c @@ -61,12 +61,12 @@ .hdp_index = DDI_HDP2 }, { /* DDI2 - DP (type C) */ - .connector_type = DDI_DP, + .connector_type = DDI_DP_W_TYPEC, .aux_index = DDI_AUX3, .hdp_index = DDI_HDP3, }, { /* DDI3 - DP (type C) */ - .connector_type = DDI_DP, + .connector_type = DDI_DP_W_TYPEC, .aux_index = DDI_AUX4, .hdp_index = DDI_HDP4, }, diff --git a/src/vendorcode/amd/fsp/mendocino/platform_descriptors.h b/src/vendorcode/amd/fsp/mendocino/platform_descriptors.h index 7dae872..a8fb257 100644 --- a/src/vendorcode/amd/fsp/mendocino/platform_descriptors.h +++ b/src/vendorcode/amd/fsp/mendocino/platform_descriptors.h @@ -142,8 +142,8 @@ DDI_DP_TO_LVDS, // DP-to-LVDS DDI_NUTMEG_DP_TO_VGA, // Hudson-2 NutMeg DP-to-VGA DDI_SINGLE_LINK_DVI_I, // Single Link DVI-I - DDI_CRT, // CRT (VGA) - DDI_LVDS, // LVDS + DDI_DP_W_TYPEC, // DP with USB type C + DDI_DP_WO_TYPEC, // DP without USB type C DDI_EDP_TO_LVDS, // eDP-to-LVDS translator chip without AMD SW init DDI_EDP_TO_LVDS_SW, // eDP-to-LVDS translator which requires AMD SW init DDI_AUTO_DETECT, // VBIOS auto detect connector type