Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32092 )
Change subject: mb/google/sarien: Call EC romstage init function ......................................................................
mb/google/sarien: Call EC romstage init function
When in romstage call into the EC init function so it can send a progress code to the EC before memory training starts.
BUG=b:127875364 TEST=boot with FSP debug and ensure EC does not try to turn off the system while it is still booting.
Change-Id: I5d99fb16bae250a82b652c530c13977e74c3378b Signed-off-by: Duncan Laurie dlaurie@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32092 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/mainboard/google/sarien/romstage.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/sarien/romstage.c b/src/mainboard/google/sarien/romstage.c index 95af0bc..e83cd4a 100644 --- a/src/mainboard/google/sarien/romstage.c +++ b/src/mainboard/google/sarien/romstage.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */
+#include <ec/google/wilco/romstage.h> #include <soc/cnl_memcfg_init.h> #include <soc/romstage.h>
@@ -49,5 +50,7 @@ .spd_smbus_address[2] = 0xa4 };
+ wilco_ec_romstage_init(); + cannonlake_memcfg_init(&memupd->FspmConfig, &memcfg, &spd); }