Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46250 )
Change subject: soc/intel/cannonlake: Improve memcfg comments ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46250/1/src/soc/intel/cannonlake/in... File src/soc/intel/cannonlake/include/soc/cnl_memcfg_init.h:
https://review.coreboot.org/c/coreboot/+/46250/1/src/soc/intel/cannonlake/in... PS1, Line 35: READ_SMBUS, /* Read on-module spd by SMBUS */
Not sure what the improvement here is? If you want to align on the periods, […]
Uh, yes. I don't know what happened here. I think I wanted to write `SPD` in uppercase, decided against it, and didn't undo all the way back
https://review.coreboot.org/c/coreboot/+/46250/1/src/soc/intel/cannonlake/in... PS1, Line 102: or left blank
FSP comment suggests that this is only true for CNL?
Good point. I can try and see what happens.