Attention is currently required from: EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/48111/comment/dcd17031_9c85786b
PS9, Line 18: default y
Let's see what CB:50118 comes up with. […]
Thanks for the pointer Angel!
As an example, after the products are released, MrChromebox oftentimes adds support for other OSes/payloads, etc. so it is perfectly valid to expect it to build with or without CHROMEOS defined here.
Eric, we can certainly add the CONFIG_CHROMEOS to our e.g., config.bry0a files, that's no problem, we just need to coordinate between our config & upstream coreboot so we don't end up with broken builds over on our side.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48111
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5311879a127a2c8da1bbb086449019d932d57b72
Gerrit-Change-Number: 48111
Gerrit-PatchSet: 9
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 29 Jan 2021 15:38:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment