Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49855 )
Change subject: soc/amd: Throw an error if FWM_POSITION_INDEX is empty
......................................................................
Patch Set 7:
(2 comments)
File src/soc/amd/cezanne/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/49855/comment/8ffa6090_64e078b6
PS5, Line 44: $(if $(CONFIG_AMD_FWM_POSITION_INDEX), ,
Maybe something like "Invalid AMD firmware position index - Check if the board sets a valid ROM siz […]
Done
File src/soc/amd/cezanne/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/49855/comment/e3828061_07caed19
PS6, Line 48: CONFIG_BOARD_ROMSIZE_KB_16384
Any reason not to add COREBOOT_ROMSIZE_KB_32768 & COREBOOT_ROMSIZE_KB_65536? They should both be sup […]
Done.
Not involved with ROM_SIZE now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49855
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iade1961460285acdec245c553c7b84014c30c267
Gerrit-Change-Number: 49855
Gerrit-PatchSet: 7
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 26 Jan 2021 07:20:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment